patch: disabled restart option for windows, as it does not work.

This commit is contained in:
Mr Finchum 2025-02-11 13:00:24 +01:00
parent 1e91ee8cf6
commit 938209fdfd
4 changed files with 24 additions and 5 deletions

View file

@ -1,9 +1,16 @@
# Changelog
## 0.12.x
### 0.12.4: Fixed EXIF File Generation Bug
### 0.12.6: Disabled app restart on Windows
- The app can not restart properly on Windows, so the restart button has been hidden when the OS is `nt`.
- Also updated tool tip to indicate that changing theme requeres are restart.
### 0.12.5: Fixed EXIF File Generation Bug
- Fixed a bug where the application failed to generate a new default EXIF file if none was available. Now, the file is correctly created when missing.
### 0.12.4: Updated README
- The README file (project description) now includes updates description and screenshots.
### 0.12.3: UI Adjustments
- Minor changes to maintain a unified layout across all windows.
- Added option to sync app theme with OS (if supported).

View file

@ -547,6 +547,12 @@ class SettingsWindow(QMainWindow, Ui_Settings_Window):
self.ui.reset_exif_Button.clicked.connect(self.ask_reset_exif)
self.ui.save_and_close_Button.clicked.connect(self.save_and_close)
self.ui.save_and_restart_Button.clicked.connect(self.save_and_restart)
if os.name == "nt": # Disable restart app when windows.
self.ui.save_and_restart_Button.setVisible(False)
self.ui.restart_checkBox.setChecked(False)
self.ui.restart_checkBox.setVisible(False)
# setting related
def load_settings_into_ui(self):

View file

@ -247,7 +247,7 @@ class Ui_Settings_Window(object):
self.groupBox_3.setTitle(QCoreApplication.translate("Settings_Window", u"Theme", None))
self.label_3.setText(QCoreApplication.translate("Settings_Window", u"Change theme from OS to PyQT Dark or Light", None))
#if QT_CONFIG(tooltip)
self.enable_theme_checkBox.setToolTip(QCoreApplication.translate("Settings_Window", u"App needs to restart before changes take effect.", None))
self.enable_theme_checkBox.setToolTip(QCoreApplication.translate("Settings_Window", u"Changes will take effect after restarting the application.", None))
#endif // QT_CONFIG(tooltip)
self.enable_theme_checkBox.setText(QCoreApplication.translate("Settings_Window", u"Custom theme", None))
self.theme_selection_comboBox.setItemText(0, QCoreApplication.translate("Settings_Window", u"Auto", None))
@ -255,7 +255,10 @@ class Ui_Settings_Window(object):
self.theme_selection_comboBox.setItemText(2, QCoreApplication.translate("Settings_Window", u"Light", None))
#if QT_CONFIG(tooltip)
self.theme_selection_comboBox.setToolTip(QCoreApplication.translate("Settings_Window", u"App needs to restart before changes take effect.", None))
self.theme_selection_comboBox.setToolTip(QCoreApplication.translate("Settings_Window", u"Changes will take effect after restarting the application.", None))
#endif // QT_CONFIG(tooltip)
#if QT_CONFIG(tooltip)
self.save_and_close_Button.setToolTip(QCoreApplication.translate("Settings_Window", u"Changes will take effect after restarting the application.", None))
#endif // QT_CONFIG(tooltip)
self.save_and_close_Button.setText(QCoreApplication.translate("Settings_Window", u"Apply theme", None))
self.install_pkg_Button.setText(QCoreApplication.translate("Settings_Window", u"Install package for custom theme", None))

View file

@ -94,7 +94,7 @@
<item row="1" column="0">
<widget class="QCheckBox" name="enable_theme_checkBox">
<property name="toolTip">
<string>App needs to restart before changes take effect.</string>
<string>Changes will take effect after restarting the application.</string>
</property>
<property name="text">
<string>Custom theme</string>
@ -122,7 +122,7 @@
</size>
</property>
<property name="toolTip">
<string>App needs to restart before changes take effect.</string>
<string>Changes will take effect after restarting the application.</string>
</property>
<item>
<property name="text">
@ -143,6 +143,9 @@
</item>
<item row="3" column="0">
<widget class="QPushButton" name="save_and_close_Button">
<property name="toolTip">
<string>Changes will take effect after restarting the application.</string>
</property>
<property name="text">
<string>Apply theme</string>
</property>